fix: use the correct URL when the user clicks "Edit on Github"#397
Merged
lachlancollins merged 2 commits intomainfrom May 6, 2025
Merged
fix: use the correct URL when the user clicks "Edit on Github"#397lachlancollins merged 2 commits intomainfrom
lachlancollins merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lachlancollins
approved these changes
May 6, 2025
LeCarbonator
pushed a commit
to LeCarbonator/tanstack.com
that referenced
this pull request
Jan 11, 2026
Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has to do with the "Edit on GitHub" link that we place at the moment of our markdown documents.
Previously, this link took the user to "view" the markdown document on GitHub.
With this change, the new link takes the user to a view designed by GitHub to encourage more native flows towards making edits.
If the user already has write-access on GitHub (which they most likely won't), then they can start making changes.
If not, the user will be asked to fork the repository, before they can begin making changes and opening a pull request (which they'd have to do anyways).